Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 18001: Bug 784519 Part 4

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by ekr-webrtc
Modified:
8 years ago
Reviewers:
abr, ekr, rescorla
Visibility:
Public.

Description

Bug 784519 Part 4

Patch Set 1 #

Total comments: 11

Patch Set 2 : Revised patches #

Total comments: 20

Patch Set 3 : Adam's next revision #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M media/webrtc/signaling/test/signaling_unittests.cpp View 1 2 22 chunks +353 lines, -86 lines 1 comment Download

Messages

Total messages: 3
rescorla
https://firefox-codereview.appspot.com/18001/diff/1/media/webrtc/signaling/test/signaling_unittests.cpp File media/webrtc/signaling/test/signaling_unittests.cpp (right): https://firefox-codereview.appspot.com/18001/diff/1/media/webrtc/signaling/test/signaling_unittests.cpp#newcode568 media/webrtc/signaling/test/signaling_unittests.cpp:568: SignalingAgent(std::string aName) : pc(nullptr), name(aName) { const std::string& aName ...
8 years, 1 month ago #1
ekr-webrtc
https://firefox-codereview.appspot.com/18001/diff/4001/media/webrtc/signaling/test/signaling_unittests.cpp File media/webrtc/signaling/test/signaling_unittests.cpp (right): https://firefox-codereview.appspot.com/18001/diff/4001/media/webrtc/signaling/test/signaling_unittests.cpp#newcode46 media/webrtc/signaling/test/signaling_unittests.cpp:46: static const char *ansiColorOff = "\x1b[0m"; Please make these ...
8 years ago #2
ekr-webrtc
8 years ago #3
lgtm with a minor nit

http://firefox-codereview.appspot.com/18001/diff/12001/media/webrtc/signaling...
File media/webrtc/signaling/test/signaling_unittests.cpp (right):

http://firefox-codereview.appspot.com/18001/diff/12001/media/webrtc/signaling...
media/webrtc/signaling/test/signaling_unittests.cpp:1954: <<
indent(a1_.getLocalDescription()) << endl << endl;
Please either use std:: or not consistently on the same line of code
here and below.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 905+:3555e821a5cd+