Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 9001: Rollup of SIPCC changes: CPR

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by ekr-webrtc
Modified:
8 years, 3 months ago
Reviewers:
ethanhugg
Visibility:
Public.

Description

Rollup of SIPCC changes: CPR

Patch Set 1 #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
A media/webrtc/signaling/src/sipcc/cpr/common/cpr_string.c View 1 chunk +131 lines, -0 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_chunk.c View 1 chunk +0 lines, -1686 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_chunk.h View 1 chunk +0 lines, -197 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_init.c View 3 chunks +0 lines, -14 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.c View 5 chunks +8 lines, -6 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.h View 1 chunk +1 line, -1 line 3 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_memory.c View 1 chunk +0 lines, -272 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_memory.h View 1 chunk +0 lines, -57 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_memory_api.h View 1 chunk +0 lines, -126 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_socket.c View 1 chunk +2 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_socket.h View 1 chunk +1 line, -1 line 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_stdlib.c View 1 chunk +0 lines, -1910 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_stdlib.h View 1 chunk +0 lines, -49 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_string.c View 1 chunk +0 lines, -94 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_string.h View 2 chunks +0 lines, -44 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_threads.c View 2 chunks +3 lines, -2 lines 2 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_timers_using_select.c View 9 chunks +30 lines, -25 lines 7 comments Download
M media/webrtc/signaling/src/sipcc/cpr/include/cpr_memory.h View 1 chunk +4 lines, -74 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/include/cpr_stdlib.h View 1 chunk +9 lines, -99 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/include/cpr_string.h View 1 chunk +45 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/include/cpr_threads.h View 1 chunk +1 line, -1 line 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_chunk.c View 1 chunk +0 lines, -1775 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_chunk.h View 1 chunk +0 lines, -201 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_ipc.c View 2 chunks +2 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_ipc.h View 1 chunk +1 line, -1 line 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_memory.c View 1 chunk +0 lines, -276 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_memory.h View 1 chunk +0 lines, -65 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_memory_api.h View 1 chunk +0 lines, -78 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_socket.c View 1 chunk +4 lines, -3 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_stdlib.c View 1 chunk +0 lines, -1854 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_stdlib.h View 1 chunk +0 lines, -49 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_string.c View 1 chunk +0 lines, -94 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_string.h View 2 chunks +0 lines, -43 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_timers_using_select.c View 5 chunks +11 lines, -14 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_init.c View 2 chunks +0 lines, -19 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_ipc.h View 1 chunk +1 line, -1 line 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_memory.c View 1 chunk +0 lines, -415 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_memory.h View 1 chunk +0 lines, -57 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_socket.c View 1 chunk +2 lines, -2 lines 1 comment Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_socket.h View 1 chunk +1 line, -2 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_stdlib.c View 1 chunk +0 lines, -67 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_stdlib.h View 1 chunk +0 lines, -144 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_string.c View 2 chunks +0 lines, -130 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_string.h View 1 chunk +0 lines, -6 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_timers.c View 3 chunks +5 lines, -10 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_types.h View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4
ekr-webrtc
https://firefox-codereview.appspot.com/9001/diff/1/media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.h File media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.h (right): https://firefox-codereview.appspot.com/9001/diff/1/media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.h#newcode50 media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.h:50: #define CPR_MAX_MSG_SIZE 8192 We're going to be sorry about ...
8 years, 3 months ago #1
ekr-webrtc
8 years, 3 months ago #2
ethanhugg
http://firefox-codereview.appspot.com/9001/diff/1/media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.h File media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.h (right): http://firefox-codereview.appspot.com/9001/diff/1/media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.h#newcode50 media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.h:50: #define CPR_MAX_MSG_SIZE 8192 We already were once which is ...
8 years, 3 months ago #3
ethanhugg
8 years, 3 months ago #4
http://firefox-codereview.appspot.com/9001/diff/1/media/webrtc/signaling/src/...
File media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.h (right):

http://firefox-codereview.appspot.com/9001/diff/1/media/webrtc/signaling/src/...
media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.h:50: #define
CPR_MAX_MSG_SIZE  8192

Filed as bug 797444

On 2012/10/02 04:44:10, ethanhugg wrote:
> We already were once which is why it's changed here.   Perhaps filing a
separate
> bug for this to be fixed after landing is the right thing here.
> 
> On 2012/10/01 17:18:24, ekr-webrtc wrote:
> > We're going to be sorry about this.
>

http://firefox-codereview.appspot.com/9001/diff/1/media/webrtc/signaling/src/...
File
media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_timers_using_select.c
(right):

http://firefox-codereview.appspot.com/9001/diff/1/media/webrtc/signaling/src/...
media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_timers_using_select.c:1163:
bzero(&tmr_client_addr, sizeof(tmr_client_addr));

You noted that they should be attrib 700 (they are created by bind).  I added a
comment about this to the bug about the tmp files - 794240.

On 2012/10/02 04:44:10, ethanhugg wrote:
> These show up in /tmp as "srwxr-xr-x", so they're writable by other processes
> run by the same user or root I would think.  We also never delete them even on
a
> clean exit.  There's a separate bug filed recently for this - 794240.  Also
much
> if this should be merged with the Linux version since the code is mostly
> duplicated.
> 
> On 2012/10/01 17:18:24, ekr-webrtc wrote:
> > What is the permissions model here? Are these files writable by other
> processes?
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 905+:3555e821a5cd+