Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(36)

Issue 41001: Bug 906990: Bcampen's refactor of some stats

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by ekr-webrtc
Modified:
7 years ago
Reviewers:
docfaraday
Visibility:
Public.

Description

Bug 906990: Bcampen's refactor of some stats

Patch Set 1 #

Total comments: 47

Patch Set 2 : Revised patches from bcampen #

Total comments: 3

Patch Set 3 : Another revision #

Total comments: 4

Patch Set 4 : Another revision #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M dom/media/PeerConnection.js View 1 chunk +7 lines, -3 lines 0 comments Download
M dom/webidl/RTCStatsReport.webidl View 1 chunk +1 line, -0 lines 0 comments Download
M media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp View 1 4 chunks +4 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/mediapipeline/MediaPipeline.h View 1 7 chunks +13 lines, -5 lines 0 comments Download
M media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp View 1 2 3 8 chunks +225 lines, -136 lines 0 comments Download
M media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h View 1 3 chunks +36 lines, -11 lines 0 comments Download
M media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M media/webrtc/signaling/test/mediapipeline_unittest.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9
ekr-webrtc
https://firefox-codereview.appspot.com/41001/diff/1/dom/media/PeerConnection.js File dom/media/PeerConnection.js (right): https://firefox-codereview.appspot.com/41001/diff/1/dom/media/PeerConnection.js#newcode124 dom/media/PeerConnection.js:124: pcref.get().getStatsInternal(null, callback, errorCallback); So this looks like the callback ...
7 years ago #1
docfaraday
Some replies, new code in a few. https://firefox-codereview.appspot.com/41001/diff/1/dom/media/PeerConnection.js File dom/media/PeerConnection.js (right): https://firefox-codereview.appspot.com/41001/diff/1/dom/media/PeerConnection.js#newcode124 dom/media/PeerConnection.js:124: pcref.get().getStatsInternal(null, callback, ...
7 years ago #2
ekr-webrtc
https://firefox-codereview.appspot.com/41001/diff/1/dom/media/PeerConnection.js File dom/media/PeerConnection.js (right): https://firefox-codereview.appspot.com/41001/diff/1/dom/media/PeerConnection.js#newcode124 dom/media/PeerConnection.js:124: pcref.get().getStatsInternal(null, callback, errorCallback); On 2014/01/02 17:28:18, docfaraday wrote: > ...
7 years ago #3
docfaraday
More discussion. https://firefox-codereview.appspot.com/41001/diff/1/dom/media/PeerConnection.js File dom/media/PeerConnection.js (right): https://firefox-codereview.appspot.com/41001/diff/1/dom/media/PeerConnection.js#newcode124 dom/media/PeerConnection.js:124: pcref.get().getStatsInternal(null, callback, errorCallback); On 2014/01/02 18:09:55, ekr-webrtc ...
7 years ago #4
docfaraday
One more note. https://firefox-codereview.appspot.com/41001/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp File media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp (right): https://firefox-codereview.appspot.com/41001/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#newcode2009 media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:2009: nsresult rv = report ? GetStatsImpl_s(internalStats, ...
7 years ago #5
ekr-webrtc
https://firefox-codereview.appspot.com/41001/diff/1/dom/media/PeerConnection.js File dom/media/PeerConnection.js (right): https://firefox-codereview.appspot.com/41001/diff/1/dom/media/PeerConnection.js#newcode124 dom/media/PeerConnection.js:124: pcref.get().getStatsInternal(null, callback, errorCallback); On 2014/01/02 18:57:34, docfaraday wrote: > ...
7 years ago #6
docfaraday
Some replies. https://firefox-codereview.appspot.com/41001/diff/1/dom/media/PeerConnection.js File dom/media/PeerConnection.js (right): https://firefox-codereview.appspot.com/41001/diff/1/dom/media/PeerConnection.js#newcode124 dom/media/PeerConnection.js:124: pcref.get().getStatsInternal(null, callback, errorCallback); On 2014/01/03 22:45:59, ekr-webrtc ...
7 years ago #7
ekr-webrtc
https://firefox-codereview.appspot.com/41001/diff/30004/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp File media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp (right): https://firefox-codereview.appspot.com/41001/diff/30004/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#newcode675 media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:675: static uint32_t pcCounter = 0; This doesn't work because ...
7 years ago #8
ekr-webrtc
7 years ago #9
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 905+:3555e821a5cd+