Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 3003: Rollup of SIPCC and PeerConnection changes

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by ekr-webrtc
Modified:
8 years, 3 months ago
CC:
snandaku_cisco.com, ehugg_cisco.com, anant_mozilla.org
Visibility:
Public.

Description

Rollup of SIPCC and PeerConnection changes

Patch Set 1 #

Total comments: 526
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M media/webrtc/signaling/include/CC_Call.h View 2 chunks +24 lines, -2 lines 5 comments Download
M media/webrtc/signaling/include/CC_CallInfo.h View 3 chunks +36 lines, -0 lines 2 comments Download
M media/webrtc/signaling/include/CC_Common.h View 1 chunk +13 lines, -13 lines 0 comments Download
M media/webrtc/signaling/include/CC_Device.h View 1 chunk +1 line, -1 line 0 comments Download
M media/webrtc/signaling/include/CC_Observer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/webrtc/signaling/include/CC_Service.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/webrtc/signaling/include/CSFVideoControl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/webrtc/signaling/include/CallControlManager.h View 3 chunks +10 lines, -11 lines 1 comment Download
M media/webrtc/signaling/include/ECC_Observer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/webrtc/signaling/include/ECC_Types.h View 3 chunks +8 lines, -7 lines 1 comment Download
M media/webrtc/signaling/include/SharedPtr.h View 1 chunk +2 lines, -3 lines 2 comments Download
M media/webrtc/signaling/signaling.gyp View 14 chunks +71 lines, -53 lines 5 comments Download
A media/webrtc/signaling/sipcc-config.mk View 1 chunk +73 lines, -0 lines 2 comments Download
M media/webrtc/signaling/src/callcontrol/CallControlManagerImpl.cpp View 7 chunks +40 lines, -75 lines 9 comments Download
M media/webrtc/signaling/src/callcontrol/CallControlManagerImpl.h View 4 chunks +9 lines, -13 lines 2 comments Download
A media/webrtc/signaling/src/common/AutoLockNSPR.h View 1 chunk +47 lines, -0 lines 1 comment Download
M media/webrtc/signaling/src/common/Wrapper.h View 1 chunk +7 lines, -5 lines 0 comments Download
M media/webrtc/signaling/src/common/csf_common.h View 2 chunks +0 lines, -13 lines 0 comments Download
A media/webrtc/signaling/src/media-conduit/AudioConduit.cpp View 1 chunk +804 lines, -0 lines 61 comments Download
A media/webrtc/signaling/src/media-conduit/AudioConduit.h View 1 chunk +212 lines, -0 lines 2 comments Download
A media/webrtc/signaling/src/media-conduit/CodecConfig.h View 1 chunk +71 lines, -0 lines 9 comments Download
A media/webrtc/signaling/src/media-conduit/MediaConduitErrors.h View 1 chunk +42 lines, -0 lines 7 comments Download
A media/webrtc/signaling/src/media-conduit/MediaConduitInterface.h View 1 chunk +309 lines, -0 lines 6 comments Download
A media/webrtc/signaling/src/media-conduit/MediaEngineWrapper.h View 1 chunk +42 lines, -0 lines 2 comments Download
A media/webrtc/signaling/src/media-conduit/VideoConduit.cpp View 1 chunk +755 lines, -0 lines 41 comments Download
A media/webrtc/signaling/src/media-conduit/VideoConduit.h View 1 chunk +217 lines, -0 lines 7 comments Download
A media/webrtc/signaling/src/media-conduit/VideoTypes.h View 1 chunk +47 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/media/CSFAudioTermination.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp View 16 chunks +986 lines, -13 lines 19 comments Download
M media/webrtc/signaling/src/media/VcmSIPCCBinding.h View 1 chunk +9 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/media/cip_mmgr_mediadefinitions.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/media/webrtc/WebrtcAudioCodecSelector.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M media/webrtc/signaling/src/media/webrtc/WebrtcAudioProvider.cpp View 11 chunks +29 lines, -28 lines 1 comment Download
M media/webrtc/signaling/src/media/webrtc/WebrtcAudioProvider.h View 2 chunks +3 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/media/webrtc/WebrtcMediaProvider.cpp View 2 chunks +23 lines, -2 lines 1 comment Download
M media/webrtc/signaling/src/media/webrtc/WebrtcToneGenerator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/media/webrtc/WebrtcVideoProvider.cpp View 17 chunks +25 lines, -24 lines 0 comments Download
M media/webrtc/signaling/src/media/webrtc/WebrtcVideoProvider.h View 2 chunks +4 lines, -3 lines 0 comments Download
A media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp View 1 chunk +729 lines, -0 lines 48 comments Download
A media/webrtc/signaling/src/mediapipeline/MediaPipeline.h View 1 chunk +364 lines, -0 lines 6 comments Download
A media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp View 1 chunk +247 lines, -0 lines 5 comments Download
A media/webrtc/signaling/src/mediapipeline/SrtpFlow.h View 1 chunk +69 lines, -0 lines 1 comment Download
A media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.cpp View 1 chunk +154 lines, -0 lines 15 comments Download
A media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.h View 1 chunk +90 lines, -0 lines 3 comments Download
A media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp View 1 chunk +1156 lines, -0 lines 151 comments Download
A media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h View 1 chunk +465 lines, -0 lines 28 comments Download
M media/webrtc/signaling/src/sipcc/core/ccapp/CCProvider.h View 1 chunk +4 lines, -0 lines 1 comment Download
M media/webrtc/signaling/src/sipcc/core/ccapp/call_logger.c View 2 chunks +9 lines, -8 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/ccapp/capability_set.c View 2 chunks +1 line, -167 lines 2 comments Download
M media/webrtc/signaling/src/sipcc/core/ccapp/cc_call_feature.c View 3 chunks +131 lines, -2 lines 6 comments Download
M media/webrtc/signaling/src/sipcc/core/ccapp/cc_device_manager.c View 3 chunks +4 lines, -13 lines 4 comments Download
M media/webrtc/signaling/src/sipcc/core/ccapp/ccapi_call.c View 1 chunk +33 lines, -14 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/ccapp/ccapi_call_info.c View 3 chunks +76 lines, -6 lines 1 comment Download
M media/webrtc/signaling/src/sipcc/core/ccapp/ccapi_config.c View 2 chunks +5 lines, -87 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/ccapp/ccapi_service.c View 4 chunks +16 lines, -12 lines 2 comments Download
M media/webrtc/signaling/src/sipcc/core/ccapp/ccapi_snapshot.c View 2 chunks +3 lines, -3 lines 1 comment Download
M media/webrtc/signaling/src/sipcc/core/ccapp/ccapp_task.c View 3 chunks +4 lines, -3 lines 2 comments Download
M media/webrtc/signaling/src/sipcc/core/ccapp/ccprovider.c View 11 chunks +78 lines, -28 lines 5 comments Download
M media/webrtc/signaling/src/sipcc/core/ccapp/conf_roster.c View 2 chunks +0 lines, -321 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/ccapp/conf_roster.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/common/cfgfile_utils.c View 1 chunk +1 line, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/common/config_api.c View 2 chunks +3 lines, -3 lines 1 comment Download
M media/webrtc/signaling/src/sipcc/core/common/config_parser.c View 9 chunks +72 lines, -1327 lines 4 comments Download
M media/webrtc/signaling/src/sipcc/core/common/config_parser.h View 4 chunks +6 lines, -45 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/common/init.c View 11 chunks +44 lines, -42 lines 3 comments Download
M media/webrtc/signaling/src/sipcc/core/common/misc.c View 4 chunks +68 lines, -382 lines 2 comments Download
M media/webrtc/signaling/src/sipcc/core/common/prot_cfgmgr_private.h View 3 chunks +25 lines, -4 lines 1 comment Download
M media/webrtc/signaling/src/sipcc/core/common/prot_configmgr.c View 3 chunks +10 lines, -1 line 2 comments Download
M media/webrtc/signaling/src/sipcc/core/common/prot_configmgr.h View 1 chunk +12 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/common/sip_socket_api.c View 3 chunks +12 lines, -12 lines 1 comment Download
M media/webrtc/signaling/src/sipcc/core/common/subscription_handler.c View 1 chunk +1 line, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/common/ui.c View 1 chunk +180 lines, -0 lines 5 comments Download
M media/webrtc/signaling/src/sipcc/core/common/vcm_util.c View 1 chunk +7 lines, -0 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/core/common/xml_util.c View 1 chunk +0 lines, -99 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/ccapi.c View 6 chunks +330 lines, -8 lines 2 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/dcsm.c View 2 chunks +2 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/fim.c View 3 chunks +15 lines, -4 lines 4 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/fsmcac.c View 1 chunk +1 line, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/fsmdef.c View 85 chunks +958 lines, -90 lines 3 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/gsm.c View 5 chunks +4 lines, -4 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c View 47 chunks +908 lines, -94 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp_crypto.c View 7 chunks +41 lines, -13 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/h/fsm.h View 7 chunks +61 lines, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/h/gsm_sdp.h View 2 chunks +14 lines, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/h/lsm.h View 3 chunks +5 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/lsm.c View 25 chunks +288 lines, -129 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/media_cap_tbl.c View 1 chunk +2 lines, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/gsm/subapi.c View 1 chunk +3 lines, -3 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/includes/ccapi.h View 12 chunks +113 lines, -23 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/includes/config.h View 1 chunk +11 lines, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/includes/debug.h View 1 chunk +0 lines, -20 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/includes/phone_platform_constants.h View 1 chunk +4 lines, -3 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/includes/platform_api.h View 1 chunk +25 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/includes/sessionConstants.h View 2 chunks +13 lines, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/includes/sessionTypes.h View 1 chunk +8 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/includes/uiapi.h View 2 chunks +20 lines, -4 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/core/includes/xml_util.h View 1 chunk +0 lines, -51 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sdp/sdp.h View 10 chunks +81 lines, -3 lines 5 comments Download
M media/webrtc/signaling/src/sipcc/core/sdp/sdp_access.c View 2 chunks +9 lines, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sdp/sdp_attr.c View 91 chunks +542 lines, -145 lines 6 comments Download
M media/webrtc/signaling/src/sipcc/core/sdp/sdp_attr_access.c View 4 chunks +767 lines, -0 lines 1 comment Download
M media/webrtc/signaling/src/sipcc/core/sdp/sdp_main.c View 4 chunks +28 lines, -3 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sdp/sdp_private.h View 6 chunks +32 lines, -8 lines 1 comment Download
M media/webrtc/signaling/src/sipcc/core/sdp/sdp_token.c View 26 chunks +67 lines, -37 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sdp/sdp_utils.c View 5 chunks +137 lines, -247 lines 1 comment Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_callinfo.c View 2 chunks +3 lines, -3 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_common_util.c View 2 chunks +2 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_core.c View 18 chunks +71 lines, -108 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_info.c View 3 chunks +1 line, -28 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_messaging.c View 8 chunks +12 lines, -12 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_platform_tcp.c View 1 chunk +1 line, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_platform_timers.c View 1 chunk +1 line, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_platform_udp.c View 2 chunks +2 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_pmh.c View 19 chunks +40 lines, -48 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_publish.c View 3 chunks +5 lines, -3 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_register.c View 5 chunks +7 lines, -9 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_spi_utils.c View 3 chunks +4 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_subsmanager.c View 8 chunks +5 lines, -55 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_task.c View 18 chunks +51 lines, -47 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/h/ccsip_platform_tcp.h View 1 chunk +1 line, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/h/ccsip_sdp.h View 2 chunks +7 lines, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/httpish.c View 5 chunks +10 lines, -7 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/sip_common_regmgr.c View 1 chunk +8 lines, -6 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/sip_common_transport.c View 1 chunk +1 line, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/sipstack/sip_platform_task.c View 7 chunks +27 lines, -14 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/src-common/dialplan.c View 2 chunks +10 lines, -9 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/src-common/dialplanint.c View 2 chunks +2 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/src-common/kpmlmap.c View 2 chunks +8 lines, -8 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/core/src-common/misc_apps_task.c View 2 chunks +2 lines, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/core/src-common/pres_sub_not_handler.c View 3 chunks +3 lines, -3 lines 0 comments Download
A media/webrtc/signaling/src/sipcc/cpr/common/cpr_string.c View 1 chunk +131 lines, -0 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_chunk.c View 1 chunk +0 lines, -1686 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_chunk.h View 1 chunk +0 lines, -197 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_init.c View 3 chunks +0 lines, -14 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.c View 5 chunks +8 lines, -6 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_ipc.h View 1 chunk +1 line, -1 line 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_memory.c View 1 chunk +0 lines, -272 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_memory.h View 1 chunk +0 lines, -57 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_memory_api.h View 1 chunk +0 lines, -126 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_socket.c View 1 chunk +2 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_socket.h View 1 chunk +1 line, -1 line 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_stdlib.c View 1 chunk +0 lines, -1910 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_stdlib.h View 1 chunk +0 lines, -49 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_string.c View 1 chunk +0 lines, -94 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_string.h View 2 chunks +0 lines, -44 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_threads.c View 2 chunks +3 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_timers_using_select.c View 9 chunks +30 lines, -25 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/include/cpr_memory.h View 1 chunk +4 lines, -74 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/include/cpr_stdlib.h View 1 chunk +9 lines, -99 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/include/cpr_string.h View 1 chunk +45 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/include/cpr_threads.h View 1 chunk +1 line, -1 line 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_chunk.c View 1 chunk +0 lines, -1775 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_chunk.h View 1 chunk +0 lines, -201 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_ipc.c View 2 chunks +2 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_ipc.h View 1 chunk +1 line, -1 line 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_memory.c View 1 chunk +0 lines, -276 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_memory.h View 1 chunk +0 lines, -65 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_memory_api.h View 1 chunk +0 lines, -78 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_socket.c View 1 chunk +4 lines, -3 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_stdlib.c View 1 chunk +0 lines, -1854 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_stdlib.h View 1 chunk +0 lines, -49 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_string.c View 1 chunk +0 lines, -94 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_string.h View 2 chunks +0 lines, -43 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_timers_using_select.c View 5 chunks +11 lines, -14 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_init.c View 2 chunks +0 lines, -19 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_ipc.h View 1 chunk +1 line, -1 line 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_memory.c View 1 chunk +0 lines, -415 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_memory.h View 1 chunk +0 lines, -57 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_socket.c View 1 chunk +2 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_socket.h View 1 chunk +1 line, -2 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_stdlib.c View 1 chunk +0 lines, -67 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_stdlib.h View 1 chunk +0 lines, -144 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_string.c View 2 chunks +0 lines, -130 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_string.h View 1 chunk +0 lines, -6 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_timers.c View 3 chunks +5 lines, -10 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_types.h View 2 chunks +11 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/include/cc_call_feature.h View 1 chunk +16 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/include/cc_config.h View 2 chunks +14 lines, -5 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/include/cc_constants.h View 7 chunks +42 lines, -5 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/include/cc_types.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/include/ccapi_call.h View 1 chunk +18 lines, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/include/ccapi_call_info.h View 2 chunks +22 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/include/ccapi_call_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M media/webrtc/signaling/src/sipcc/include/ccapi_service.h View 1 chunk +11 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/include/ccsdp.h View 2 chunks +30 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/include/config_api.h View 2 chunks +2 lines, -55 lines 0 comments Download
A media/webrtc/signaling/src/sipcc/include/peer_connection_types.h View 1 chunk +67 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/include/plat_api.h View 2 chunks +0 lines, -83 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/include/vcm.h View 8 chunks +178 lines, -3 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/include/xml_parser.h View 1 chunk +0 lines, -82 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/plat/common/libxml_parser.c View 1 chunk +0 lines, -982 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/plat/common/plat_sec_api.c View 1 chunk +0 lines, -126 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/plat/darwin/plat_api_stub.c View 1 chunk +0 lines, -10 lines 0 comments Download
R media/webrtc/signaling/src/sipcc/plat/linux/plat_api_stub.c View 1 chunk +0 lines, -519 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/plat/win32/mystub.c View 1 chunk +0 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/plat/win32/plat_api_stub.c View 8 chunks +30 lines, -54 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/plat/win32/plat_api_win.c View 2 chunks +2 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/sipcc/stub/vcm_stub.c View 3 chunks +19 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/softphonewrapper/CC_SIPCCCall.cpp View 7 chunks +71 lines, -10 lines 2 comments Download
M media/webrtc/signaling/src/softphonewrapper/CC_SIPCCCall.h View 4 chunks +17 lines, -5 lines 0 comments Download
M media/webrtc/signaling/src/softphonewrapper/CC_SIPCCCallInfo.cpp View 2 chunks +186 lines, -0 lines 0 comments Download
M media/webrtc/signaling/src/softphonewrapper/CC_SIPCCCallInfo.h View 3 chunks +9 lines, -2 lines 0 comments Download
M media/webrtc/signaling/src/softphonewrapper/CC_SIPCCDevice.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
M media/webrtc/signaling/src/softphonewrapper/CC_SIPCCDevice.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/webrtc/signaling/src/softphonewrapper/CC_SIPCCService.cpp View 16 chunks +26 lines, -129 lines 1 comment Download
M media/webrtc/signaling/src/softphonewrapper/CC_SIPCCService.h View 2 chunks +7 lines, -19 lines 0 comments Download
M media/webrtc/signaling/src/softphonewrapper/ccapi_plat_api_impl.cpp View 5 chunks +6 lines, -5 lines 1 comment Download
A media/webrtc/signaling/test/FakeMediaStreams.h View 1 chunk +225 lines, -0 lines 1 comment Download
A media/webrtc/signaling/test/FakeMediaStreamsImpl.h View 1 chunk +200 lines, -0 lines 8 comments Download
A media/webrtc/signaling/test/Makefile.in View 1 chunk +101 lines, -0 lines 4 comments Download
A media/webrtc/signaling/test/mediaconduit_unittests.cpp View 1 chunk +713 lines, -0 lines 0 comments Download
A media/webrtc/signaling/test/mediapipeline_unittest.cpp View 1 chunk +232 lines, -0 lines 0 comments Download
A media/webrtc/signaling/test/resource_mgr.h View 1 chunk +71 lines, -0 lines 0 comments Download
A media/webrtc/signaling/test/signaling_unittests.cpp View 1 chunk +866 lines, -0 lines 0 comments Download
A media/webrtc/signaling/test/webrtc_standalone_test.cpp View 1 chunk +398 lines, -0 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/DOCBparser.h View 1 chunk +0 lines, -96 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/HTMLparser.h View 1 chunk +0 lines, -304 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/HTMLtree.h View 1 chunk +0 lines, -147 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/SAX.h View 1 chunk +0 lines, -173 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/SAX2.h View 1 chunk +0 lines, -176 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/c14n.h View 1 chunk +0 lines, -126 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/catalog.h View 1 chunk +0 lines, -182 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/chvalid.h View 1 chunk +0 lines, -230 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/debugXML.h View 1 chunk +0 lines, -217 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/dict.h View 1 chunk +0 lines, -69 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/encoding.h View 1 chunk +0 lines, -226 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/entities.h View 1 chunk +0 lines, -150 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/globals.h View 1 chunk +0 lines, -502 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/hash.h View 1 chunk +0 lines, -233 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/list.h View 1 chunk +0 lines, -137 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/nanoftp.h View 1 chunk +0 lines, -143 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/nanohttp.h View 1 chunk +0 lines, -81 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/parser.h View 1 chunk +0 lines, -1235 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/parserInternals.h View 1 chunk +0 lines, -611 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/pattern.h View 1 chunk +0 lines, -100 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/relaxng.h View 1 chunk +0 lines, -213 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/schemasInternals.h View 1 chunk +0 lines, -958 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/schematron.h View 1 chunk +0 lines, -142 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/threads.h View 1 chunk +0 lines, -84 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/tree.h View 1 chunk +0 lines, -1252 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/uri.h View 1 chunk +0 lines, -94 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/valid.h View 1 chunk +0 lines, -458 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xinclude.h View 1 chunk +0 lines, -129 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xlink.h View 1 chunk +0 lines, -189 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlIO.h View 1 chunk +0 lines, -360 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlautomata.h View 1 chunk +0 lines, -146 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlerror.h View 1 chunk +0 lines, -944 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlexports.h View 1 chunk +0 lines, -162 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlmemory.h View 1 chunk +0 lines, -224 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlmodule.h View 1 chunk +0 lines, -57 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlreader.h View 1 chunk +0 lines, -424 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlregexp.h View 1 chunk +0 lines, -222 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlsave.h View 1 chunk +0 lines, -87 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlschemas.h View 1 chunk +0 lines, -218 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlschemastypes.h View 1 chunk +0 lines, -151 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlstring.h View 1 chunk +0 lines, -140 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlunicode.h View 1 chunk +0 lines, -202 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlversion.h View 1 chunk +0 lines, -458 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xmlwriter.h View 1 chunk +0 lines, -485 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xpath.h View 1 chunk +0 lines, -546 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xpathInternals.h View 1 chunk +0 lines, -630 lines 0 comments Download
R media/webrtc/signaling/third_party/libxml2/include/libxml/xpointer.h View 1 chunk +0 lines, -114 lines 0 comments Download

Messages

Total messages: 43
ekr-webrtc
Here is the rietveld upload
8 years, 4 months ago #1
ekr-webrtc
This is a review of the first chunk of this code, up to where the ...
8 years, 4 months ago #2
suhas.nandakumar
Few questions on some comments .. Still not looked into entire list ... http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/AudioConduit.cpp File ...
8 years, 3 months ago #3
suhas.nandakumar
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/CodecConfig.h File media/webrtc/signaling/src/media-conduit/CodecConfig.h (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/CodecConfig.h#newcode24 media/webrtc/signaling/src/media-conduit/CodecConfig.h:24: int mRate; On 2012/09/22 15:13:06, ekr-webrtc wrote: > In ...
8 years, 3 months ago #4
ekr-webrtc
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/AudioConduit.cpp File media/webrtc/signaling/src/media-conduit/AudioConduit.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/AudioConduit.cpp#newcode50 media/webrtc/signaling/src/media-conduit/AudioConduit.cpp:50: if(mRecvCodecList[i]) On 2012/09/25 00:03:25, suhas.nandakumar wrote: > On 2012/09/22 ...
8 years, 3 months ago #5
suhas.nandakumar
Incorporated almost all the comments with couple of questions ... I will be uploading patch ...
8 years, 3 months ago #6
ekr-webrtc
Suhas, A lot of my comments don't have responses which makes it hard to see ...
8 years, 3 months ago #7
suhas.nandakumar
Sending it in batches .. Since my earlier attempt seems not to have reflected my ...
8 years, 3 months ago #8
suhas.nandakumar
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/MediaConduitErrors.h File media/webrtc/signaling/src/media-conduit/MediaConduitErrors.h (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/MediaConduitErrors.h#newcode15 media/webrtc/signaling/src/media-conduit/MediaConduitErrors.h:15: kMediaConduitNoError = 0, On 2012/09/22 15:13:06, ekr-webrtc wrote: > ...
8 years, 3 months ago #9
suhas.nandakumar
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/VideoConduit.h File media/webrtc/signaling/src/media-conduit/VideoConduit.h (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/VideoConduit.h#newcode15 media/webrtc/signaling/src/media-conduit/VideoConduit.h:15: // Video Engine Includes On 2012/09/22 15:13:06, ekr-webrtc wrote: ...
8 years, 3 months ago #10
suhas.nandakumar
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/AudioConduit.cpp File media/webrtc/signaling/src/media-conduit/AudioConduit.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/AudioConduit.cpp#newcode241 media/webrtc/signaling/src/media-conduit/AudioConduit.cpp:241: mEngineTransmitting = false; On 2012/09/25 05:32:40, suhas.nandakumar wrote: > ...
8 years, 3 months ago #11
suhas.nandakumar
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/MediaEngineWrapper.h File media/webrtc/signaling/src/media-conduit/MediaEngineWrapper.h (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/MediaEngineWrapper.h#newcode11 media/webrtc/signaling/src/media-conduit/MediaEngineWrapper.h:11: #include "common_types.h" On 2012/09/22 15:13:06, ekr-webrtc wrote: > These ...
8 years, 3 months ago #12
suhas.nandakumar
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/CodecConfig.h File media/webrtc/signaling/src/media-conduit/CodecConfig.h (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/CodecConfig.h#newcode24 media/webrtc/signaling/src/media-conduit/CodecConfig.h:24: int mRate; On 2012/09/25 00:15:10, ekr-webrtc wrote: > On ...
8 years, 3 months ago #13
jesup
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp File media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp#newcode35 media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp:35: #endif Already removed this in the merge. All the ...
8 years, 3 months ago #14
ekr-webrtc
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/AudioConduit.cpp File media/webrtc/signaling/src/media-conduit/AudioConduit.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media-conduit/AudioConduit.cpp#newcode678 media/webrtc/signaling/src/media-conduit/AudioConduit.cpp:678: WebrtcAudioConduit::IsSamplingFreqSupported(int freq) const On 2012/09/25 23:47:23, suhas.nandakumar wrote: > ...
8 years, 3 months ago #15
jesup
Comments on the rest of the file. One big issue: planar_ycrcb buffer access. http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp File ...
8 years, 3 months ago #16
jesup
One big issue here (probably): key buffer lifetime http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp File media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp#newcode75 media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp:75: static_cast<const ...
8 years, 3 months ago #17
ekr-webrtc
Checkpoint of my reviews http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/ccapp/ccapi_service.c File media/webrtc/signaling/src/sipcc/core/ccapp/ccapi_service.c (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/ccapp/ccapi_service.c#newcode102 media/webrtc/signaling/src/sipcc/core/ccapp/ccapi_service.c:102: // if (is_action_to_be_deferred(STOP_ACTION) == TRUE) ...
8 years, 3 months ago #18
jesup
Covering signaling SDP code and also FakeMediaStreams (Sorry for mixing them) http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/sdp/sdp.h File media/webrtc/signaling/src/sipcc/core/sdp/sdp.h (right): ...
8 years, 3 months ago #19
jesup
Reviews on a numbe of softphonewrapper/CC_SIP* files, and ccapi_plat_api_impl.cpp http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/softphonewrapper/CC_SIPCCCall.cpp File media/webrtc/signaling/src/softphonewrapper/CC_SIPCCCall.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/softphonewrapper/CC_SIPCCCall.cpp#newcode588 media/webrtc/signaling/src/softphonewrapper/CC_SIPCCCall.cpp:588: ...
8 years, 3 months ago #20
ekr-webrtc
More reviews... http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/common/init.c File media/webrtc/signaling/src/sipcc/core/common/init.c (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/common/init.c#newcode317 media/webrtc/signaling/src/sipcc/core/common/init.c:317: Spurious tab. http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/common/init.c#newcode344 media/webrtc/signaling/src/sipcc/core/common/init.c:344: if (FALSE == ...
8 years, 3 months ago #21
jesup
Partly through both PeerConnectionImpl.h/cpp http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.cpp File media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.cpp#newcode26 media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.cpp:26: * the terms of any ...
8 years, 3 months ago #22
ethanhugg
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/common/misc.c File media/webrtc/signaling/src/sipcc/core/common/misc.c (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/common/misc.c#newcode330 media/webrtc/signaling/src/sipcc/core/common/misc.c:330: /** In patch 2 of bug 790504 this was ...
8 years, 3 months ago #23
ekr-webrtc
Updated comments http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/gsm/fim.c File media/webrtc/signaling/src/sipcc/core/gsm/fim.c (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/gsm/fim.c#newcode439 media/webrtc/signaling/src/sipcc/core/gsm/fim.c:439: Spurious whitespace. http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/gsm/fim.c#newcode468 media/webrtc/signaling/src/sipcc/core/gsm/fim.c:468: Whitespace only change. ...
8 years, 3 months ago #24
ethanhugg
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/signaling.gyp File media/webrtc/signaling/signaling.gyp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/signaling.gyp#newcode504 media/webrtc/signaling/signaling.gyp:504: # './src/sipcc/core/src-common/md5.c', This is back in now that libjingle ...
8 years, 3 months ago #25
jesup
Phew! Done with PeerConnectionImpl http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp File media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#newcode690 media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:690: nsresult rv = NS_NewDOMDataChannel(channel, mWindow ...
8 years, 3 months ago #26
jesup
Some additional minor comments http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.cpp File media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.cpp#newcode125 media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.cpp:125: void PeerConnectionCtx::onDeviceEvent(ccapi_device_event_e deviceEvent, CSF::CC_DevicePtr device, ...
8 years, 3 months ago #27
ethanhugg
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/signaling.gyp File media/webrtc/signaling/signaling.gyp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/signaling.gyp#newcode202 media/webrtc/signaling/signaling.gyp:202: '-Werror', I'm guessing that all of these -Werrors need ...
8 years, 3 months ago #28
ethanhugg
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/ccapp/cc_call_feature.c File media/webrtc/signaling/src/sipcc/core/ccapp/cc_call_feature.c (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/ccapp/cc_call_feature.c#newcode112 media/webrtc/signaling/src/sipcc/core/ccapp/cc_call_feature.c:112: callFeature.featData.ccData.info = strlib_malloc(data, strlen(data)); strlib_malloc is probably poorly named. ...
8 years, 3 months ago #29
suhas.nandakumar
I will be uploading the parts that are addressed and fixed in a patch tomorrow ...
8 years, 3 months ago #30
jesup
There are a lot of "deferred" and "let ekr handle this" responses - we need ...
8 years, 3 months ago #31
ethanhugg
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/softphonewrapper/CC_SIPCCCall.cpp File media/webrtc/signaling/src/softphonewrapper/CC_SIPCCCall.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/softphonewrapper/CC_SIPCCCall.cpp#newcode588 media/webrtc/signaling/src/softphonewrapper/CC_SIPCCCall.cpp:588: // FIX - add info to dcb for use ...
8 years, 3 months ago #32
ethanhugg
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp File media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#newcode1026 media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:1026: // FIXME: Dispatch on main thread. The pattern for ...
8 years, 3 months ago #33
suhas.nandakumar
Few more changed in ... http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h File media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h#newcode71 media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h:71: nsRefPtr<mozilla::SharedBuffer> samples = mozilla::SharedBuffer::Create(4000); ...
8 years, 3 months ago #34
suhas.nandakumar
few more replies http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.h File media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.h (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.h#newcode26 media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.h:26: * the terms of any one ...
8 years, 3 months ago #35
jesup
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h File media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h#newcode71 media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h:71: nsRefPtr<mozilla::SharedBuffer> samples = mozilla::SharedBuffer::Create(4000); On 2012/10/03 18:55:32, suhas.nandakumar wrote: ...
8 years, 3 months ago #36
ethanhugg
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/ccapp/capability_set.c File media/webrtc/signaling/src/sipcc/core/ccapp/capability_set.c (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/sipcc/core/ccapp/capability_set.c#newcode295 media/webrtc/signaling/src/sipcc/core/ccapp/capability_set.c:295: sstrncpy(g_fp_version_stamp, "", sizeof(g_fp_version_stamp)); Changed in 792188 patch 10. On ...
8 years, 3 months ago #37
suhas.nandakumar
updated more comments on discussing with Ethan http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp File media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#newcode325 media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:325: NS_ProxyRelease(mainThread, mPCObserver); ...
8 years, 3 months ago #38
suhas.nandakumar
updated more comments on discussing with Ethan
8 years, 3 months ago #39
ethanhugg
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/include/CC_Call.h File media/webrtc/signaling/include/CC_Call.h (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/include/CC_Call.h#newcode314 media/webrtc/signaling/include/CC_Call.h:314: virtual void addIceCandidate(const std::string& strCandidate) = 0; addIceCandidate and ...
8 years, 3 months ago #40
jesup
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp File media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp (right): http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp#newcode617 media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp:617: At least return here and MOZ_ASSERT http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp#newcode622 media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp:622: PR_ASSERT(stream.get()); ...
8 years, 3 months ago #41
suhas.nandakumar
Had 2 open questions 1. on ChangeReadyState and dispatching it to Main thread and its ...
8 years, 3 months ago #42
ethanhugg
8 years, 3 months ago #43
http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/...
File media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp (right):

http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/...
media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp:617: 

All PR_ASSERTs changed to MOZ_ASSERT.  This block now dose CSFLogError and
return.

On 2012/10/04 03:38:47, jesup wrote:
> At least return here and MOZ_ASSERT

http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/...
media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp:623: if (!stream.get()) {

Removed .get()s throughout the file except after  GetMainThread() and when
they're params to a printf-style log message.

On 2012/10/04 03:38:47, jesup wrote:
> get rid of the .get()'s (repeat across file)

http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/...
media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp:649:
sstrncpy((*candidatesp)[i], candidates[i].c_str(), candidates[i].size() + 1);

cpr_malloc has been def'd to moz_xmalloc so it is now infallible.

On 2012/10/04 03:38:47, jesup wrote:
> Either cpr_malloc is infallible, and we can do this, or it's fallible and we
> need the stuff elsewhere in this function where we check the result.  One or
the
> other should change

http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/...
media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp:693: if
(attrs[i].compare(0, 9, "ice-ufrag") == 0) {

Changing this to compare(0, strlen("ice-ufrag:), "ice-ufrag:") and similarly for
the one below.

On 2012/10/04 03:38:47, jesup wrote:
> Where does it check for the : after ice-ufrag?  What if it's
> iceufragnotreally:foo?

http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/...
media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp:717: free(pwd);

Also changing these to cpr_free

On 2012/10/04 03:38:47, jesup wrote:
> free(NULL) is safe, so drop the if's

http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/...
media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp:1281:
pc->impl()->GetMainThread().get(),

This will throw an error if removed.  Can't find the sig of StorePipeline.  I'm
leaving it in.  The other alternative would be to cast it.

On 2012/10/04 03:38:47, jesup wrote:
> remove .get()

http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/...
media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp:1319: ; // Ignore

Adding CSFLogError() and return here.

On 2012/10/04 03:38:47, jesup wrote:
> Log?  Assert?

http://firefox-codereview.appspot.com/3003/diff/1/media/webrtc/signaling/src/...
media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp:1861: ; // Ignore

Adding CSFLogError() and return here.

On 2012/10/04 03:38:47, jesup wrote:
> log or assert
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 905+:3555e821a5cd+