Issue 28001: Issue 825708: use interface properties to determine priorities

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 28001: Issue 825708: use interface properties to determine priorities

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 5 months ago by kk1fff-patrick-wang

Modified:
7 years, 5 months ago

Reviewers:
ekr-webrtc

Visibility:
Public.

More Reviews

Description

Issue 825708: use interface properties to determine priorities

Patch Set 1 #

Created: 7 years, 5 months ago

Download raw patch set

	Unified diffs	Side-by-side diffs	Stats			Patch
M	media/mtransport/gonk_addrs.cpp	View	5 chunks	+25 lines, -5 lines	0 comments	Download
M	media/mtransport/nricectx.cpp	View	2 chunks	+15 lines, -0 lines	0 comments	Download
A	media/mtransport/nrinterfaceprioritizer.cpp	View	1 chunk	+191 lines, -0 lines	0 comments	Download
A +	media/mtransport/nrinterfaceprioritizer.h	View	1 chunk	+10 lines, -11 lines	0 comments	Download
M	media/mtransport/objs.mk	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	media/mtransport/test/ice_unittest.cpp	View	3 chunks	+80 lines, -0 lines	0 comments	Download
M	media/mtransport/third_party/nICEr/nicer.gyp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	media/mtransport/third_party/nICEr/src/ice/ice_candidate.c	View	1 chunk	+26 lines, -13 lines	0 comments	Download
M	media/mtransport/third_party/nICEr/src/ice/ice_component.c	View	5 chunks	+17 lines, -6 lines	0 comments	Download
M	media/mtransport/third_party/nICEr/src/ice/ice_ctx.c	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	media/mtransport/third_party/nICEr/src/ice/ice_ctx.h	View	3 chunks	+3 lines, -0 lines	0 comments	Download
A +	media/mtransport/third_party/nICEr/src/net/local_addr.c	View	1 chunk	+22 lines, -47 lines	0 comments	Download
A +	media/mtransport/third_party/nICEr/src/net/local_addr.h	View	3 chunks	+25 lines, -8 lines	0 comments	Download
A +	media/mtransport/third_party/nICEr/src/net/nr_interface_prioritizer.c	View	1 chunk	+51 lines, -49 lines	0 comments	Download
A +	media/mtransport/third_party/nICEr/src/net/nr_interface_prioritizer.h	View	1 chunk	+23 lines, -42 lines	0 comments	Download
M	media/mtransport/third_party/nICEr/src/net/nr_socket.c	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/mtransport/third_party/nICEr/src/net/transport_addr.c	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	media/mtransport/third_party/nICEr/src/net/transport_addr.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/mtransport/third_party/nICEr/src/stun/addrs.c	View	20 chunks	+94 lines, -33 lines	0 comments	Download
M	media/mtransport/third_party/nICEr/src/stun/addrs.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	media/mtransport/third_party/nICEr/src/stun/stun_util.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/mtransport/third_party/nICEr/src/stun/stun_util.h	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Thanks. I see this and will try to review today.

Expand All Messages | Collapse All Messages