Issue 23001: Bug 889615: Granular logging

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 23001: Bug 889615: Granular logging

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 6 months ago by ekr-webrtc

Modified:
7 years, 6 months ago

Reviewers:

Visibility:
Public.

More Reviews

Description

Bug 889615: Granular logging

Patch Set 1 #

Total comments: 1

Patch Set 2 : Revised patch #

Created: 7 years, 6 months ago

Download raw patch set

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	media/mtransport/dtlsidentity.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/mtransport/logging.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	media/mtransport/nricectx.cpp	View	1	8 chunks	+23 lines, -23 lines	0 comments	Download
M	media/mtransport/nricemediastream.cpp	View	1	5 chunks	+11 lines, -11 lines	0 comments	Download
M	media/mtransport/nriceresolver.cpp	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	media/mtransport/test/transport_unittests.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/mtransport/transportflow.cpp	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	media/mtransport/transportlayer.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/mtransport/transportlayerdtls.cpp	View	1	9 chunks	+52 lines, -52 lines	0 comments	Download
M	media/mtransport/transportlayerice.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/mtransport/transportlayerlog.cpp	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	media/mtransport/transportlayerloopback.cpp	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	media/mtransport/transportlayerprsock.cpp	View	1	1 chunk	+11 lines, -11 lines	0 comments	Download
M	media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp	View	1	20 chunks	+39 lines, -39 lines	0 comments	Download
M	media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp	View	1	2 chunks	+21 lines, -21 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

ekr-webrtc

7 years, 6 months ago #1

Please do one patch that *just* renames the log levels from PR_LOG to MOZ_MTLOG
or whatever. Then we can discuss relevelling.

https://firefox-codereview.appspot.com/23001/diff/1/media/mtransport/logging.h
File media/mtransport/logging.h (right):

https://firefox-codereview.appspot.com/23001/diff/1/media/mtransport/logging....
media/mtransport/logging.h:32: #define LOG_DEBUG        5
These are already defined in syslog.h.

You need to do something like MOZ_MTLOG_EMERG....

Expand All Messages | Collapse All Messages