Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 22001: Issue 825708: use interface properties to determine priorities

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by ekr-webrtc
Modified:
7 years, 5 months ago
Visibility:
Public.

Description

Issue 825708: use interface properties to determine priorities

Patch Set 1 #

Total comments: 15

Patch Set 2 : Revised patches #

Total comments: 29

Patch Set 3 : Revision #

Total comments: 29

Patch Set 4 : Revised version #

Patch Set 5 : Revised again #

Patch Set 6 : Another try #

Total comments: 5

Patch Set 7 : Revised #

Patch Set 8 : Revision 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M media/mtransport/nricectx.cpp View 1 2 3 7 2 chunks +15 lines, -0 lines 0 comments Download
A media/mtransport/nrinterfaceprioritizer.cpp View 1 2 3 4 5 6 7 1 chunk +191 lines, -0 lines 0 comments Download
A media/mtransport/nrinterfaceprioritizer.h View 1 2 3 7 1 chunk +18 lines, -0 lines 0 comments Download
M media/mtransport/objs.mk View 1 2 3 7 2 chunks +3 lines, -1 line 0 comments Download
M media/mtransport/third_party/nICEr/src/ice/ice_candidate.c View 1 2 3 7 1 chunk +26 lines, -13 lines 0 comments Download
M media/mtransport/third_party/nICEr/src/ice/ice_component.c View 1 2 3 7 1 chunk +11 lines, -0 lines 0 comments Download
M media/mtransport/third_party/nICEr/src/ice/ice_ctx.c View 1 7 2 chunks +16 lines, -0 lines 0 comments Download
M media/mtransport/third_party/nICEr/src/ice/ice_ctx.h View 1 7 3 chunks +3 lines, -0 lines 0 comments Download
A media/mtransport/third_party/nICEr/src/net/nr_interface_prioritizer.c View 1 2 3 7 1 chunk +87 lines, -0 lines 0 comments Download
A media/mtransport/third_party/nICEr/src/net/nr_interface_prioritizer.h View 1 7 1 chunk +66 lines, -0 lines 0 comments Download
M media/mtransport/third_party/nICEr/src/net/transport_addr.c View 1 2 7 1 chunk +21 lines, -0 lines 0 comments Download
M media/mtransport/third_party/nICEr/src/net/transport_addr.h View 1 2 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14
ekr-webrtc
Please write some unit tests to exercise this functionality http://firefox-codereview.appspot.com/22001/diff/1/media/mtransport/nricectx.cpp File media/mtransport/nricectx.cpp (right): http://firefox-codereview.appspot.com/22001/diff/1/media/mtransport/nricectx.cpp#newcode344 media/mtransport/nricectx.cpp:344: ...
7 years, 6 months ago #1
kk1fff-patrick-wang
http://firefox-codereview.appspot.com/22001/diff/1/media/mtransport/third_party/nICEr/src/ice/ice_ctx.c File media/mtransport/third_party/nICEr/src/ice/ice_ctx.c (right): http://firefox-codereview.appspot.com/22001/diff/1/media/mtransport/third_party/nICEr/src/ice/ice_ctx.c#newcode175 media/mtransport/third_party/nICEr/src/ice/ice_ctx.c:175: int nr_ice_ctx_set_interface_priority(nr_ice_ctx *ctx, nr_interface_priority *ip) On 2013/07/01 14:05:49, ekr-webrtc ...
7 years, 6 months ago #2
kk1fff-patrick-wang
7 years, 6 months ago #3
ekr-webrtc
http://firefox-codereview.appspot.com/22001/diff/1/media/mtransport/third_party/nICEr/src/ice/ice_ctx.c File media/mtransport/third_party/nICEr/src/ice/ice_ctx.c (right): http://firefox-codereview.appspot.com/22001/diff/1/media/mtransport/third_party/nICEr/src/ice/ice_ctx.c#newcode175 media/mtransport/third_party/nICEr/src/ice/ice_ctx.c:175: int nr_ice_ctx_set_interface_priority(nr_ice_ctx *ctx, nr_interface_priority *ip) On 2013/07/02 08:32:32, kk1fff-patrick-wang ...
7 years, 6 months ago #4
ekr-webrtc
https://firefox-codereview.appspot.com/22001/diff/9001/media/mtransport/nricectx.cpp File media/mtransport/nricectx.cpp (right): https://firefox-codereview.appspot.com/22001/diff/9001/media/mtransport/nricectx.cpp#newcode344 media/mtransport/nricectx.cpp:344: #ifndef USE_INTERFACE_PRIORITY_FALLBACK When is this going to be set? ...
7 years, 6 months ago #5
kk1fff-patrick-wang
I have updated the patch on bugzilla and have run unit test on Linux (platform ...
7 years, 6 months ago #6
ekr-webrtc
https://firefox-codereview.appspot.com/22001/diff/24001/media/mtransport/nricectx.cpp File media/mtransport/nricectx.cpp (right): https://firefox-codereview.appspot.com/22001/diff/24001/media/mtransport/nricectx.cpp#newcode373 media/mtransport/nricectx.cpp:373: r = nr_ice_ctx_set_interface_prioritizer(ctx->ctx_, CreateIntefacePrioritizer()); Error check needed for failure ...
7 years, 5 months ago #7
kk1fff-patrick-wang
http://firefox-codereview.appspot.com/22001/diff/24001/media/mtransport/nricectx.cpp File media/mtransport/nricectx.cpp (right): http://firefox-codereview.appspot.com/22001/diff/24001/media/mtransport/nricectx.cpp#newcode373 media/mtransport/nricectx.cpp:373: r = nr_ice_ctx_set_interface_prioritizer(ctx->ctx_, CreateIntefacePrioritizer()); On 2013/08/09 19:56:34, ekr-webrtc wrote: ...
7 years, 5 months ago #8
ekr-webrtc
https://firefox-codereview.appspot.com/22001/diff/28003/media/mtransport/nrinterfaceprioritizer.cpp File media/mtransport/nrinterfaceprioritizer.cpp (right): https://firefox-codereview.appspot.com/22001/diff/28003/media/mtransport/nrinterfaceprioritizer.cpp#newcode28 media/mtransport/nrinterfaceprioritizer.cpp:28: MOZ_MTLOG(PR_LOG_ERROR, "Error formating interface address string."); typo "formatting" https://firefox-codereview.appspot.com/22001/diff/28003/media/mtransport/third_party/nICEr/src/ice/ice_component.c ...
7 years, 5 months ago #9
kk1fff-patrick-wang
https://firefox-codereview.appspot.com/22001/diff/28003/media/mtransport/third_party/nICEr/src/ice/ice_component.c File media/mtransport/third_party/nICEr/src/ice/ice_component.c (right): https://firefox-codereview.appspot.com/22001/diff/28003/media/mtransport/third_party/nICEr/src/ice/ice_component.c#newcode179 media/mtransport/third_party/nICEr/src/ice/ice_component.c:179: nr_socket *sock; On 2013/08/15 23:51:05, ekr-webrtc wrote: > This ...
7 years, 5 months ago #10
ekr-webrtc
https://firefox-codereview.appspot.com/22001/diff/28003/media/mtransport/third_party/nICEr/src/ice/ice_component.c File media/mtransport/third_party/nICEr/src/ice/ice_component.c (right): https://firefox-codereview.appspot.com/22001/diff/28003/media/mtransport/third_party/nICEr/src/ice/ice_component.c#newcode179 media/mtransport/third_party/nICEr/src/ice/ice_component.c:179: nr_socket *sock; On 2013/08/19 03:56:27, kk1fff-patrick-wang wrote: > On ...
7 years, 5 months ago #11
kk1fff-patrick-wang
https://firefox-codereview.appspot.com/22001/diff/28003/media/mtransport/third_party/nICEr/src/ice/ice_component.c File media/mtransport/third_party/nICEr/src/ice/ice_component.c (right): https://firefox-codereview.appspot.com/22001/diff/28003/media/mtransport/third_party/nICEr/src/ice/ice_component.c#newcode179 media/mtransport/third_party/nICEr/src/ice/ice_component.c:179: nr_socket *sock; On 2013/08/19 21:05:16, ekr-webrtc wrote: > On ...
7 years, 5 months ago #12
ekr
Ah. Do you think you could just upload this to a new Rietveld issue? -Ekr ...
7 years, 5 months ago #13
kk1fff-patrick-wang
7 years, 5 months ago #14
I've uploaded to 28001, but it seems the 3 parts of the patch are mixed together
in the issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 905+:3555e821a5cd+